8000 handle BrokenResourceError gracefully by lingster · Pull Request #237 · modelcontextprotocol/python-sdk · GitHub
[go: up one dir, main page]
Skip to content

handle BrokenResourceError gracefully #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

handle BrokenResourceError gracefully #237

wants to merge 1 commit into from

Conversation

lingster
Copy link
@lingster lingster commented Mar 1, 2025

Improved Error handling when a BrokenResourceError occurs

Motivation and Context

With my mcp server, I occasionally get this error which renders my claude session unusable.

How Has This Been Tested?

Tested my mcp server with Claude Desktop

Breaking Changes

No breaking changes

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • [x ] I have read the MCP Documentation
  • [x ] My code follows the repository's style guidelines
  • [x ] New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

dsp-ant
dsp-ant requested changes Mar 3, 2025
View reviewed changes
Copy link
Member
@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the stream is rendered unusable as indicated by a BrokenResourceError, we should handle this appropriately. I don't think ignoring is the right appraoch. We likely want to close the connection at this point. Clients should graefully restart the process.

mcp-shadow[bot]
mcp-shadow bot reviewed May 13, 2025
View reviewed changes
Copy link
@mcp-shadow mcp-shadow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to the MCP Python SDK!

Your PR addresses a valid issue with handling BrokenResourceError in the stdio transport. However, as there has been no activity on this PR for over 2 months, I'm closing it at this time.

We appreciate your effort in identifying and attempting to fix this issue. If you decide to refresh this PR with the suggested improvements, please feel free to reopen it or submit a new one.

@mcp-shadow mcp-shadow bot closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcp-shadow mcp-shadow[bot] mcp-shadow[bot] left review comments

@dsp-ant dsp-ant dsp-ant requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lingster @dsp-ant
0