8000 make CallToolResult.content non-optional and relax output schema validation requirement by bhosmer-ant · Pull Request #559 · modelcontextprotocol/modelcontextprotocol · GitHub
[go: up one dir, main page]
Skip to content

make CallToolResult.content non-optional and relax output schema validation requirement #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

make CallToolResult.content non-optional and relax output schema validation requirement #559

merged 2 commits into from
May 21, 2025
+53 −228

Conversation

bhosmer-ant
Copy link
Contributor

In service of compatibility and flexibility, make two changes around structured tool results:

  • restore CallToolResult.content to non-optional status, making the introduction of structuredContent purely a additive change.
  • relax spec language around output schema validation from MUST to SHOULD.

Motivation and Context

Changes were motivated by backward compatibility considerations.

How Has This Been Tested?

Tracking changes/tests in TypeScript SDK to follow.

Breaking Changes

Spec is still in draft. However, this actually reduces the delta in the draft spec.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@bhosmer-ant bhosmer-ant requested a review from ihrpr May 21, 2025 14:33
@bhosmer-ant bhosmer-ant force-pushed the basil/nonoptional_content branch from 5208273 to e03d811 Compare May 21, 2025 14:52
@bhosmer-ant bhosmer-ant force-pushed the basil/nonoptional_content branch from e03d811 to 2ade607 Compare May 21, 2025 15:18
@bhosmer-ant bhosmer-ant force-pushed the basil/nonoptional_content branch 2 times, most recently from f4ad723 to 2368f65 Compare May 21, 2025 15:20
ihrpr
ihrpr previously approved these changes 8000 May 21, 2025
View reviewed changes
Copy link
Contributor
@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhosmer-ant bhosmer-ant force-pushed the basil/nonoptional_content branch from 2368f65 to 4742501 Compare May 21, 2025 15:39
@ihrpr ihrpr merged commit 901ac03 into main May 21, 2025
5 checks passed
@ihrpr ihrpr deleted the basil/nonoptional_content branch May 21, 2025 15:51
This was referenced May 21, 2025
Merged
Merged
@sushichan044 sushichan044 mentioned this pull request Jun 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihrpr ihrpr ihrpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhosmer-ant @ihrpr
0