Make schema.ts the source of truth for error codes
#1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhefner
commented
Sep 26, 2025
Comment on lines
+678
to
+680
| export interface InvalidResourceError extends Error { | ||
| code: -32002; | ||
| } |
There was a problem hiding this comment.
We could also explicitly define the message and data properties here, e.g.:
Suggested change
| export interface InvalidResourceError extends Error { | |
| code: -32002; | |
| } | |
| export interface InvalidResourceError extends Error { | |
| code: -32002; | |
| message: "Resource not found"; | |
| data: { | |
| uri: string; | |
| }; | |
| } |
(Per this example.)
Comment on lines
+783
to
+789
| export interface InvalidPromptError { | ||
| code: -32602; | ||
| } | ||
|
|
||
| export interface InvalidPromptArgumentsError { | ||
| code: -32602; | ||
| } |
There was a problem hiding this comment.
Another way to do this is to define a union type for the error message, e.g.:
Suggested change
| export interface InvalidPromptError { | |
| code: -32602; | |
| } | |
| export interface InvalidPromptArgumentsError { | |
| code: -32602; | |
| } | |
| export interface PromptError { | |
| code: -32602; | |
| message: | |
| | "Invalid prompt name" | |
| | "Missing required arguments"; | |
| } |
Though it may better to keep them separate if we want to define the data property as well.
774b0bc to
f6f6445
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make
schema.tsthe source of truth for which error codes to use in various scenarios. This was inspired by #509 and #1545.I have added some comments for further discussion.