client: fix example, and update refs to old modules #50484
Merged
+42
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Jul 23, 2025
Comment on lines
+110
to
+111
| // It is a fork of [platforms.Format], and does not yet support "os.version", | ||
| // as [[platforms.FormatAll] does. |
There was a problem hiding this comment.
I'll be opening a ticket for this; the TL;DR is that docker container create does not currently support passing os.version, which gets silently discarded, but the daemon would be able to handle it.
I'm considering that perhaps we should move away from using the ?platform= query-arg (which uses the string format, not JSON), and adding information in the body (HostConfig?) that can hold information that was passed to resolve the image (name of image, requested platform?)
robmry
approved these changes
Jul 23, 2025
vvoland
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Human readable description for the release notes< 8000 /strong>
- A picture of a cute animal (not mandatory but encouraged)