-
Notifications
You must be signed in to change notification settings - Fork 18.8k
api/types: remove deprecated aliases #50452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AkihiroSuda
merged 22 commits into
moby:master
from
thaJeztah:api_remove_deprecated_aliases
Jul 21, 2025
Merged
api/types: remove deprecated aliases #50452
AkihiroSuda
merged 22 commits into
moby:master
from
thaJeztah:api_remove_deprecated_aliases
Jul 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aliases were added in 3d1e4d9, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types`; - `ImageBuildOptions` - `ImageBuildOutput` - `ImageBuildResponse` - `BuilderVersion` - `BuilderV1` - `BuilderBuildKit` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This alias was added in bb7dbaa, which shipped in the latest v28.x releases, so we can remove this. This removes the deprecated `api/types.BuildResult` type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These aliases were added in eefe68a, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types`; - `BuildCache` - `BuildCachePruneOptions` - `BuildCachePruneReport` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This alias was added in 7e8f630, which shipped in the latest v28.x releases, so we can remove this. This removes the deprecated `api/types.SwarmUnlockKeyResponse` type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These aliases were added in b135285, which shipped in the latest v28.x releases, so we can remove this. This removes the deprecated `api/types.ServiceListOptions` and `api/types.ServiceInspectOptions` types. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These aliases were added in 0b1c7a8, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types`; - `ServiceUpdateOptions` - `RegistryAuthFromSpec` - `RegistryAuthFromPreviousSpec` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These aliases were added in 31d6293, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types.ServiceCreateOptions` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These was added in 5ad0867, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types.TaskListOptions` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These was added in f008d85, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types.NodeListOptions` and `NodeRemoveOptions`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These was added in a411a39, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types.ConfigCreateResponse` and `ConfigListOptions`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These was added in 23117af, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types.SecretCreateResponse` and `SecretListOptions`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These was added in 7053007, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types.ImageInspect` and `RootFS`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These was added in da039ca, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types.GraphDriverData`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These was added in e12b749, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types.Port`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These was added in 5517322, which shipped in the latest v28.x releases, so we can remove these. This removes the deprecated `api/types.MountPoint`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was added in c130ce1, which shipped in the latest v28.x releases, so we can remove these. This removes the `Health` and `HealthcheckResult` types to the container package, as well as the related `NoHealthcheck`, `Starting`, `Healthy`, and `Unhealthy` consts. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was added in df22a51, which shipped in the latest v28.x releases, so we can remove these. This removes the NetworkSettings, NetworkSettingsBase, DefaultNetworkSettings, and SummaryNetworkSettings types. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was added in 84ffc64, which shipped in the latest v28.x releases, so we can remove these. This removes the ContainerState type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was added in 05b0e65, which shipped in the latest v28.x releases, so we can remove these. This removes the Container type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was added in 1abc8f6, which shipped in the latest v28.x releases, so we can remove these. This removes the `ContainerJSONBase`, `ContainerJSON` types. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was added in b99b542, which shipped in the latest v28.x releases, so we can remove these. This removes the `IDResponse` type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was added in bb899c6, which shipped in the latest v28.x releases, so we can remove these. This removes the `RequestPrivilegeFunc` type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
AkihiroSuda
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; probably you could safely remove these aliases in a single commit
This was referenced Aug 4, 2025
This was referenced Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/api
API
area/go-sdk
impact/deprecation
impact/go-sdk
Noteworthy (compatibility changes) in the Go SDK
status/2-code-review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
api/types: remove deprecated build-related types
These aliases were added in 3d1e4d9,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types
;ImageBuildOptions
ImageBuildOutput
ImageBuildResponse
BuilderVersion
BuilderV1
BuilderBuildKit
api/types: remove deprecated BuildResult
This alias was added in bb7dbaa,
which shipped in the latest v28.x releases, so we can remove this.
This removes the deprecated
api/types.BuildResult
type.api/types: remove deprecated build-cache types
These aliases were added in eefe68a,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types
;BuildCache
BuildCachePruneOptions
BuildCachePruneReport
api/types: remove deprecated SwarmUnlockKeyResponse
This alias was added in 7e8f630,
which shipped in the latest v28.x releases, so we can remove this.
This removes the deprecated
api/types.SwarmUnlockKeyResponse
type.api/types: remove deprecated ServiceListOptions, ServiceInspectOptions
These aliases were added in b135285,
which shipped in the latest v28.x releases, so we can remove this.
This removes the deprecated
api/types.ServiceListOptions
andapi/types.ServiceInspectOptions
types.api/types: remove deprecated ServiceUpdateOptions
These aliases were added in 0b1c7a8,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types
;ServiceUpdateOptions
RegistryAuthFromSpec
RegistryAuthFromPreviousSpec
api/types: remove deprecated ServiceCreateOptions
These aliases were added in 31d6293,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types.ServiceCreateOptions
api/types: remove deprecated TaskListOptions
These was added in 5ad0867,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types.TaskListOptions
api/types: remove deprecated NodeListOptions, NodeRemoveOptions
These was added in f008d85,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types.NodeListOptions
andNodeRemoveOptions
.api/types: remove deprecated ConfigCreateResponse, ConfigListOptions
These was added in a411a39,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types.ConfigCreateResponse
andConfigListOptions
.api/types: remove deprecated SecretCreateResponse, SecretListOptions
These was added in 23117af,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types.SecretCreateResponse
andSecretListOptions
.api/types: remove deprecated ImageInspect, RootFS
These was added in 7053007,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types.ImageInspect
andRootFS
.api/types: remove deprecated GraphDriverData
These was added in da039ca,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types.GraphDriverData
.api/types: remove deprecated Port
These was added in e12b749,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types.Port
.api/types: remove deprecated MountPoint
These was added in 5517322,
which shipped in the latest v28.x releases, so we can remove these.
This removes the deprecated
api/types.MountPoint
.api/types: remove deprecated container Health types
This was added in c130ce1,
which shipped in the latest v28.x releases, so we can remove these.
This removes the
Health
andHealthcheckResult
types to the container package,as well as the related
NoHealthcheck
,Starting
,Healthy
, andUnhealthy
consts.
api/types: remove deprecated container-networksettings types
This was added in df22a51,
which shipped in the latest v28.x releases, so we can remove these.
This removes the NetworkSettings, NetworkSettingsBase, DefaultNetworkSettings,
and SummaryNetworkSettings types.
api/types: remove deprecated ContainerState type
This was added in 84ffc64,
which shipped in the latest v28.x releases, so we can remove these.
This removes the ContainerState type.
api/types: remove deprecated Container type
This was added in 05b0e65,
which shipped in the latest v28.x releases, so we can remove these.
This removes the Container type.
api/types: remove deprecated container-inspect types
This was added in 1abc8f6,
which shipped in the latest v28.x releases, so we can remove these.
This removes the
ContainerJSONBase
,ContainerJSON
types.api/types: remove deprecated IDResponse type
This was added in b99b542,
which shipped in the latest v28.x releases, so we can remove these.
This removes the
IDResponse
type.api/types: remove deprecated RequestPrivilegeFunc type
This was added in bb899c6,
which shipped in the latest v28.x releases, so we can remove these.
This removes the
RequestPrivilegeFunc
type.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)