8000 client: ContainerExecAttach: update GoDoc links by thaJeztah · Pull Request #50411 · moby/moby · GitHub
[go: up one dir, main page]

Skip to content

Conversation

thaJeztah
Copy link
Member
  • Use doc-links for references to other types.
  • Fix reference to "types.HijackedConnection", which doesn't exist.
  • Use a bullet-list for the different stream formats used.

Before this PR:

pkgsite -open -http=:6060 .
Screenshot 2025-07-15 at 10 45 59

With this PR:

Screenshot 2025-07-15 at 10 45 08

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

- Use doc-links for references to other types.
- Fix reference to "types.HijackedConnection", which doesn't exist.
- Use a bullet-list for the different stream formats used.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@AkihiroSuda AkihiroSuda merged commit 543c433 into moby:master Jul 16, 2025
228 of 231 checks passed
@thaJeztah thaJeztah deleted the client_ContainerExecAttach_linkify branch July 16, 2025 06:30
@thaJeztah thaJeztah added this to the 29.0.0 milestone Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0