8000 [27.x backport] daemon/graphdriver/zfs: ignore non-existent dataset on removal by thaJeztah · Pull Request #48968 · moby/moby · GitHub
[go: up one dir, main page]

Skip to content

Conversation

thaJeztah
Copy link
Member

- What I did

I updated the Remove function to ignore the "dataset does not exist" error

- How I did it

Doing a strings.Contains of "dataset does not exist" in err

- How to verify it

- Description for the changelog

Ignores "dataset does not exist" error when removing dataset on ZFS (#43080)

image

Ignore "dataset does not exist" error in Remove function

Signed-off-by: François Scala <github@arcenik.net>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit e7d15d4)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Contributor
@robmry robmry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 7f11005 into moby:27.x Nov 27, 2024
147 checks passed
@thaJeztah thaJeztah deleted the 27.x_backport_43080-zfs-destroy-missing-volume-fails branch November 27, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0