[27.x backport] client: prevent idle connections leaking FDs #48764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch from tonistiigi@af6ada9 Without this change, if a long-lived process uses the client and creates connections, these connections are not released and grow over time. We can also look into addressing this issue from the server side, but it doesn't hurt for the `client` package to have good defaults and not cause this. Signed-off-by: Laura Brehm <laurabrehm@hey.com> (cherry picked from commit 5c72a95) Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch from tonistiigi@af6ada9
- What I did
Without this change, if a long-lived process is using the client, idle connections are not released and grow over time.
We can also look into addressing this issue from the server side, but it doesn't hurt for the
clientpackage to have good defaults and not cause this.- How I did it
Set
MaxIdleConnsandIdleConnTimeouton thedefaultHTTPClient.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)