8000 [27.x] c8d/httpfallback: Handle connection errors by vvoland · Pull Request #48758 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

[27.x] c8d/httpfallback: Handle connection errors #48758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

[27.x] c8d/httpfallback: Handle connection errors #48758

merged 1 commit into from
Oct 25, 2024

Conversation

vvoland
Copy link
Contributor
@vvoland vvoland commented Oct 25, 2024 •
edited
Loading

Note: This only targets the 27.x branch, as #47380 (for master branch) will remove our httpFallback and use the one from containerd.

This is a minimal patch that aligns the httpFallback implementation to support the same fallback conditions as the containerd one.

- What I did
Adjust the httpFallback implementation to also handle non-TLS related errors which can also happen when issuing a HTTPS requested to HTTP-only registries.

- Description for the changelog

containerd image store: Fix not being able to connect to some insecure registries in cases where the HTTPS request failed due to a non-TLS related error.

- A picture of a cute animal (not mandatory but encouraged)

@vvoland vvoland added status/2-code-review kind/bugfix PR's that fix bugs containerd-integration Issues and PRs related to containerd integration labels Oct 25, 2024
@vvoland vvoland added this to the 27.4.0 milestone Oct 25, 2024
@vvoland vvoland self-assigned this Oct 25, 2024
@vvoland vvoland requested review from dmcgowan and thaJeztah October 25, 2024 11:32
thaJeztah
thaJeztah reviewed Oct 25, 2024
View reviewed changes
thaJeztah
thaJeztah approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

LGTM

@vvoland
c8d/httpfallback: Handle connection errors
de01359 
Adjust the httpFallback implementation to also handle non-TLS related
errors which can also happen when issuing a HTTPS requested to HTTP-only
registries.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland force-pushed the c8d-httpfallback-adjust branch from ddf384b to de01359 Compare October 25, 2024 11:44
@thaJeztah thaJeztah merged commit b37ecae into moby:27.x Oct 25, 2024
140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@laurazard laurazard laurazard approved these changes

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

Assignees

@vvoland vvoland

Labels
containerd-integration Issues and PRs related to containerd integration kind/bugfix PR's that fix bugs status/2-code-review
Projects
containerd integration
Status: Done
Milestone
27.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vvoland @thaJeztah @laurazard
0