8000 [19.03 backport] dockerd-rootless.sh: support new containerd shim socket path convention by AkihiroSuda · Pull Request #41557 · moby/moby · GitHub
[go: up one dir, main page]

Skip to content

Conversation

AkihiroSuda
Copy link
Member

The new shim socket path convention hardcodes /run/containerd: containerd/containerd#4343

dockerd-rootless.sh is updated to hide the rootful /run/containerd from the mount namespace of the rootless dockerd.

Cherry-pick #41156

The new shim socket path convention hardcodes `/run/containerd`:
containerd/containerd#4343

`dockerd-rootless.sh` is updated to hide the rootful `/run/containerd`
from the mount namespace of the rootless dockerd.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 794aa20)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the 19.03.14 milestone Oct 16, 2020
@AkihiroSuda AkihiroSuda changed the title [19.03 backport] dockerd-rootless.sh: support containerd v1.4 shim socket path convention [19.03 backport] dockerd-rootless.sh: support new containerd shim socket path convention Oct 16, 2020
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit bb69504 into moby:19.03 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0