8000 Remove apt.dockerproject.org from test by thaJeztah · Pull Request #41270 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

Remove apt.dockerproject.org from test #41270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

Remove apt.dockerproject.org from test #41270

merged 1 commit into from
Jul 28, 2020

Conversation

thaJeztah
Copy link
Member

@thaJeztah
Remove apt.dockerproject.org from test
aa22597 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Jul 27, 2020
Merged
@thaJeztah
Copy link
Member Author

@tonistiigi @tiborvass @cpuguy83 PTAL

cpuguy83
cpuguy83 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah mentioned this pull request Jul 27, 2020
Merged
@tonistiigi
Copy link
Member

Many other references to apt.dockerproject.org in this repo. Mostly under docs/ but also in hack/

@thaJeztah
Copy link
Member Author

I see some tests using org.dockerproject but that's because those are reserved. There's a couple of references to dockerproject.org related to jenkins and an old mailinglist; I'll have a look at those separately

@thaJeztah
Copy link
Member Author

Rootless tests failed after timing out; failure is unrelated;

=== RUN   TestCgroupNamespacesRunHostMode
--- FAIL: TestCgroupNamespacesRunHostMode (60.00s)
    run_cgroupns_linux_test.go:34: [d4cc358a78c40] failed to start daemon with arguments [-u unprivilegeduser -E XDG_RUNTIME_DIR=/go/src/github.com/docker/docker/bundles/test-integration/TestCgroupNamespacesRunHostMode/d4cc358a78c40/xdgrun -E HOME=/home/unprivilegeduser -E PATH=/go/src/github.com/docker/docker/bundles/test-integration/../dynbinary-daemon:/go/src/github.com/docker/docker/bundles/test-integration/../binary-daemon:/usr/local/cli:/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin -- dockerd-rootless.sh --data-root /go/src/github.com/docker/docker/bundles/test-integration/TestCgroupNamespacesRunHostMode/d4cc358a78c40/root --exec-root /tmp/dxr/d4cc358a78c40 --pidfile /go/src/github.com/docker/docker/bundles/test-integration/TestCgroupNamespacesRunHostMode/d4cc358a78c40/docker.pid --userland-proxy=true --containerd-namespace d4cc358a78c40 --containerd-plugins-namespace d4cc358a78c40p --default-cgroupns-mode private --host unix:///tmp/docker-integration/d4cc358a78c40.sock --debug --storage-driver overlay2] : [d4cc358a78c40] daemon exited and never started: context deadline exceeded

@thaJeztah thaJeztah merged commit c430c8d into moby:master Jul 28, 2020
@thaJeztah thaJeztah deleted the remove_dockerproject_from_tests branch July 28, 2020 07:34
@thaJeztah thaJeztah added this to the 20.03.0 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@tiborvass tiborvass tiborvass approved these changes

Assignees
No one assigned
Labels
area/testing process/cherry-picked status/4-merge
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @tonistiigi @cpuguy83 @tiborvass
0