vendor runc libraryv1.0.0-rc91-48-g67169a9d #41178
Conversation
94d1b74 to
5553d95
Compare
5553d95 to
b410ba2
Compare
|
When start the container with |
daemon/stats/collector_unix.go
Outdated
There was a problem hiding this comment.
Perhaps this should now just be a const clockTicksPerSecond (grouped with the nanoSecondsPerSecond below), and then we can remove the clockTicksPerSecond property, and platformNewStatsCollector().
I think this change would make sense as a separate commit (or even a separate PR)
|
Lots of failures, though. :( |
|
Opened #41186 to address #41178 (comment) |
b410ba2 to
af58581
Compare
af58581 to
00325f3
Compare
|
I found that the final error message comes from The I checked the value it got, e.g. dest: node: Checking. |
|
I think we need #41016 as well |
Thanks. Let me take a look. |
I tried to merge it in and test it locally. But the error encountered here still exists. |
|
#41016 was merged; could you rebase the PR (to check if it helps with the failures) |
|
sure! |
00325f3 to
cd6f452
Compare
|
The problem still exists, when the Even if I upgrade containerd to v1.4.0 (#40982 ), the problem is the same. |
|
needs rebase |
|
opened #41288 |
|
👌 Thanks |
fc9b827 to
1b79bb1
Compare
|
CI passed 👍 |
There was a problem hiding this comment.
Should we have the containerd/cgroups in a separate PR / commit, so that we can cherry-pick this fix for Go 1.14 in the 19.03 branch @AkihiroSuda ?
There was a problem hiding this comment.
let's just merge #41253 and we will have the latest containerd/cgroups
There was a problem hiding this comment.
Ah, yes, forgot that one was updating it; merged it
There was a problem hiding this comment.
Looks like we need to update this one as well (perhaps also separate because IIRC, this is to fix issues with Go 1.14); containerd/containerd#4334
There was a problem hiding this comment.
OK, I create a separate commit. (Will push soon)
There was a problem hiding this comment.
Perhaps we need to update these as well to match containerd/containerd@963625d
|
thanks！ let me update it |
v1.4.0-beta.1-150-g779ef602 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
v1.0.0-rc91-48-g67169a9d Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
github.com/prometheus/client_golang to v1.6.0 github.com/prometheus/client_model to v0.2.0 github.com/prometheus/common to v0.9.1 github.com/prometheus/procfs to v0.0.11 Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
1b79bb1 to
9f28837
Compare
|
@thaJeztah PTAL. Thanks |
| }() | ||
| } | ||
| if fifos.Stderr != "" { | ||
| if !fifos.Terminal && fifos.Stderr != "" { |
There was a problem hiding this comment.
I see this fixes a potential panic; containerd/containerd#3611, but I think that was related to a change that's only in 1.3.x, so I guess no need to get that into the 19.03 branch
|
Added "cherry-pick" label to consider backporting some of the dependency bumps related to Go 1.14 fixes |
full diff opencontainers/runc@v1.0.0-rc10...v1.0.0-rc91