10BC0 [19.03] vendor: docker/libnetwork 026aabaa659832804b01754aaadd2c0f420c68b6 (bump_19.03 branch) by thaJeztah · Pull Request #41124 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

[19.03] vendor: docker/libnetwork 026aabaa659832804b01754aaadd2c0f420c68b6 (bump_19.03 branch) #41124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

[19.03] vendor: docker/libnetwork 026aabaa659832804b01754aaadd2c0f420c68b6 (bump_19.03 branch) #41124

merged 1 commit into from
Jun 18, 2020

Conversation

thaJeztah
Copy link
Member
@thaJeztah thaJeztah < 8000 /strong> commented Jun 17, 2020

full diff: moby/libnetwork@153d076...026aaba

Note that we may want to have the local changes from #41011 as well, but that one isn't merged yet on master

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
vendor: docker/libnetwork 026aabaa659832804b01754aaadd2c0f420c68b6 (b…
b4ca19a 
…ump_19.03 branch)

full diff: moby/libnetwork@153d076...026aaba

- Fix 'failed to get network during CreateEndpoint'
- log error instead if disabling IPv6 router advertisement failed

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.12 milestone Jun 17, 2020
@thaJeztah thaJeztah requested a review from tianon as a code owner June 17, 2020 14:03
@thaJeztah
Copy link
Member Author

Note that we may want to have the local changes from #41011 as well, but that one isn't merged yet on master

@arkodg could use some input on that ^

@tiborvass
Copy link
Contributor

I don't understand #41011 but without that, docker/for-linux#888 is not really fixed: I get an error saying the network does not exist. Was testing with docker/for-linux#888 (comment) (needs docker swarm init)

@tiborvass tiborvass mentioned this pull request Jun 17, 2020
Closed
3 tasks
cpuguy83
cpuguy83 approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

8D44
@cpuguy83 cpuguy83 merged commit 9dc6525 into moby:19.03 Jun 18, 2020
@thaJeztah thaJeztah deleted the 19.03_bump_libnetwork branch June 18, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@tiborvass tiborvass tiborvass approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees
No one assigned
Labels
area/networking Networking status/2-code-review
Projects
None yet
Milestone
19.03.12
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @tiborvass @cpuguy83
0