10BC0 [19.03] vendor: swarmkit 0b8364e7d08aa0e972241eb59ae981a67a587a0e by thaJeztah · Pull Request #40831 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

[19.03] vendor: swarmkit 0b8364e7d08aa0e972241eb59ae981a67a587a0e #40831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

[19.03] vendor: swarmkit 0b8364e7d08aa0e972241eb59ae981a67a587a0e #40831

merged 1 commit into from
Apr 17, 2020

Conversation

thaJeztah
Copy link
Member

full diff: moby/swarmkit@062b694...0b8364e

@thaJeztah
[19.03] vendor: swarmkit 0b8364e7d08aa0e972241eb59ae981a67a587a0e
e4f239d 
full diff: moby/swarmkit@062b694...0b8364e

- Fix leaking tasks.db

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.9 milestone Apr 16, 2020
@thaJeztah
Copy link
Member Author

@cpuguy83 @SamWhited @dperny PTAL

SamWhited
SamWhited approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor
@SamWhited SamWhited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran vndr and nothing changes and the commit appears right so LGTM.

cpuguy83
cpuguy83 approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 6a0995e into moby:19.03 Apr 17, 2020
@thaJeztah thaJeztah deleted the 19.03_bump_swarmkit branch April 17, 2020 07:56
@thaJeztah thaJeztah mentioned this pull request May 29, 2020
Closed
@mellertson
Copy link

For the uninitiated, what is LGTM short for?

@thaJeztah
Copy link
Member Author

"look good to me"

@tnir tnir mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@SamWhited SamWhited SamWhited approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/swarm kind/bugfix PR's that fix bugs status/2-code-review
Projects
None yet
Milestone
19.03.9
Development

Successfully merging this pull request may close these issues.
5 participants
@thaJeztah @mellertson @SamWhited @cpuguy83 @AkihiroSuda
0