8000 [19.03 backport] Move schema1 deprecation notice by thaJeztah · Pull Request #40681 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

[19.03 backport] Move schema1 deprecation notice #40681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

[19.03 backport] Move schema1 deprecation notice #40681

merged 1 commit into from
Apr 2, 2020

Conversation

thaJeztah
Copy link
Member
@thaJeztah thaJeztah 8000 commented Mar 12, 2020

backport of #40671
fixes docker/for-linux#942 for 19.03

Currently we show this deprecation notice for any error returned by a
registry.
Registries can return an error for any number of reasons.
Instead let's show the deprecation notice only if the fallback was
successful.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@cpuguy83 @thaJeztah
Move schema1 deprecation notice
100d240 
Currently we show this deprecation notice for any error returned by a
registry.
Registries can return an error for any number of reasons.
Instead let's show the deprecation notice only if the fallback was
successful.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 6859bc7)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added area/distribution Image Distribution status/2-code-review kind/bugfix PR's that fix bugs labels Mar 12, 2020
@thaJeztah thaJeztah added this to the 19.03.9 milestone Mar 12, 2020
@cpuguy83 cpuguy83 mentioned this pull request Mar 12, 2020
Closed
cpuguy83
cpuguy83 approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 5ed8f9a into moby:19.03 Apr 2, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_schema2v1_dep_notice_on_error_only branch April 2, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees
No one assigned
Labels
area/distribution Image Distribution kind/bugfix PR's that fix bugs status/4-merge
Projects
None yet
Milestone
19.03.9
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @tonistiigi @cpuguy83
0