8000 [19.03 backport] Use FILE_SHARE_DELETE for log files on Windows. by thaJeztah · Pull Request #40563 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

[19.03 backport] Use FILE_SHARE_DELETE for log files on Windows. #40563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

[19.03 backport] Use FILE_SHARE_DELETE for log files on Windows. #40563

merged 1 commit into from
Apr 17, 2020

Conversation

thaJeztah
Copy link
Member
@thaJeztah thaJeztah 8000 commented Feb 22, 2020

backport of #39974

This (hopefully! 🤞 ) fixes issues where one goroutine tries to delete or rename a file
while another goroutine has the file open (e.g. a log reader).

Closes #39856
Closes #36801
Fixes #39274

@cpuguy83 @thaJeztah
Use FILE_SHARE_DELETE for log files on Windows.
1a83050 
This fixes issues where one goroutine tries to delete or rename a file
while another goroutine has the file open (e.g. a log reader).

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit a5f237c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.8 milestone Feb 22, 2020
cpuguy83
cpuguy83 approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah modified the milestones: 19.03.8, 19.03.9 Mar 11, 2020
@thaJeztah
Copy link
Member Author

@AkihiroSuda this one looking good to you as well?

@AkihiroSuda AkihiroSuda merged commit f432f71 into moby:19.03 Apr 17, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_fix_windows_file_handles branch April 17, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/logging impact/changelog platform/windows status/2-code-review
Projects
None yet
Milestone
19.03.9
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @cpuguy83 @AkihiroSuda
0