8000 [19.03 backport] vendor: update opencontainers/selinux v1.3.1 by thaJeztah · Pull Request #40547 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

[19.03 backport] vendor: update opencontainers/selinux v1.3.1 #40547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

[19.03 backport] vendor: update opencontainers/selinux v1.3.1 #40547

merged 1 commit into from
Feb 25, 2020

Conversation

thaJeztah
Copy link
Member

@thaJeztah
vendor: update opencontainers/selinux v1.3.1
2b130c2 
full diff: opencontainers/selinux@5215b18...v1.3.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 12c7541)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.7 milestone Feb 20, 2020
cpuguy83
cpuguy83 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit a515a32 into moby:19.03 Feb 25, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_update_selinux_v1.3.1 branch February 25, 2020 08:45
@RobbKistler
Copy link

@thaJeztah I'm tracking down an SELinux issue in moby/moby somewhere between 19.03.5 and 19.03.8. The full diff of the opencontainers is much larger than this vendoring change -- is that just because the vendoring only only pulling in a subset of the files?

@thaJeztah
Copy link
Member Author

@RobbKistler correct; vndr pulls in only the parts of a dependency that we use (granularity is per "directory" / "package"). Any part that's not pulled in, is not used in our code base

@thaJeztah
Copy link
Member Author

if you install an older version of the engine (and/or containerd+runc) the issue doesn't reproduce? It's also possible things changed in the containers-selinux package (we've had issues with that in the past)

@thaJeztah
Copy link
Member Author

@RobbKistler I think your question relates to #40944, let's continue there

This was referenced May 10, 2020
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/security/selinux status/2-code-review
Projects
None yet
Milestone
19.03.7
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @RobbKistler @cpuguy83 @AkihiroSuda
0