[19.03] Update Golang 1.12.17 #40533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: golang/go@go1.12.16...go1.12.17 go1.12.17 (released 2020/02/12) includes a fix to the runtime. See the Go 1.12.17 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.12.17+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
AkihiroSuda
approved these changes
Feb 17, 2020
|
LGTM, but can we upgrade to 1.13? 1.12 will reach EOL soon. |
|
Yes, we should probably update to 1.13 in an upcoming patch release (I can prepare PR's for that). Given that we'll likely have to do a new (19.03.7) release soon (to included an updated containerd version to address the regression in containerd 1.2.12; containerd/containerd#4033), I'd like to reduce the number of changes for 19.03.7 if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: golang/go@go1.12.16...go1.12.17
go1.12.17 (released 2020/02/12) includes a fix to the runtime. See the Go 1.12.17
milestone on the issue tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.12.17+label%3ACherryPickApproved
- Description for the changelog