8000 API: update docs that /session left experimental in V1.39 by thaJeztah · Pull Request #40028 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

API: update docs that /session left experimental in V1.39 #40028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2019
Merged

API: update docs that /session left experimental in V1.39 #40028

merged 1 commit into from
Oct 18, 2019

Conversation

thaJeztah
Copy link
Member
@thaJeztah thaJeztah commented Oct 2, 2019 •
edited
Loading

The /session endpoint left experimental in API V1.39 / Docker 18.09 through 239047c and 01c9e70 (#37686), but the API reference was not updated accordingly.

This updates the API documentation to match the change.

- Description for the changelog

* API: update docs that `/session` endpoint left experimental in V1.39 [moby/moby#40028](https://github.com/moby/moby/pull/40028)

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah force-pushed the session_endpoint_docs_updates branch from bf8b2ba to cfa8184 Compare October 2, 2019 10:21
This was referenced Oct 2, 2019
Merged
Merged
@thaJeztah
API: update docs that /session left experimental in V1.39
6756f5f 
The `/session` endpoint left experimental in API V1.39 through
239047c and
01c9e70, but the API reference
was not updated accordingly.

This updates the API documentation to match the change.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the session_endpoint_docs_updates branch from cfa8184 to 6756f5f Compare October 2, 2019 10:30
@thaJeztah
Copy link
Member Author

@tiborvass @andrewhsu PTAL

This was referenced Oct 2, 2019
Merged
Merged
@thaJeztah
Copy link
Member Author

Looks like the TestInspect test has really become flaky;

[2019-10-02T10:57:28.767Z] === FAIL: amd64.integration.service TestInspect (11.90s)
[2019-10-02T10:57:28.767Z]     inspect_test.go:23: Creating a new daemon at: "/go/src/github.com/docker/docker/bundles/test-integration/TestInspect"
[2019-10-02T10:57:28.767Z]     inspect_test.go:39: timeout hit after 10s: waiting for tasks to enter run state. task failed with error: task: non-zero exit (1)

@thaJeztah
Copy link
Member Author

argh why does this fail? is master broken on this? Drew's PR also showed this problem, and I thought it was related to his changes, but maybe not;

[2019-10-03T21:22:54.521Z] panic: object has no key "default"
[2019-10-03T21:22:54.521Z] 
[2019-10-03T21:22:54.521Z] goroutine 1 [running]:
[2019-10-03T21:22:54.521Z] github.com/go-swagger/go-swagger/vendor/github.com/go-openapi/validate.NewSchemaValidator(0xc0011a2fc0, 0xbaf840, 0xc0011a2fc0, 0x0, 0x0, 0xd11940, 0xc00043d380, 0x40)
[2019-10-03T21:22:54.522Z] 	/tmp/tmp.hjT43OgVuH/src/github.com/go-swagger/go-swagger/vendor/github.com/go-openapi/validate/schema.go:55 +0xf68
[2019-10-03T21:22:54.522Z] github.com/go-swagger/go-swagger/vendor/github.com/go-openapi/validate.(*SpecValidator).Validate(0xc001159b78, 0xb69820, 0xc0006aa4c0, 0xc0011a2fc0, 0xc000922180)
[2019-10-03T21:22:54.522Z] 	/tmp/tmp.hjT43OgVuH/src/github.com/go-swagger/go-swagger/vendor/github.com/go-openapi/validate/spec.go:102 +0x132
[2019-10-03T21:22:54.522Z] github.com/go-swagger/go-swagger/vendor/github.com/go-openapi/validate.Spec(0xc0006aa4c0, 0xd11940, 0xc00043d380, 0x0, 0x0)
[2019-10-03T21:22:54.522Z] 	/tmp/tmp.hjT43OgVuH/src/github.com/go-swagger/go-swagger/vendor/github.com/go-openapi/validate/spec.go:50 +0xa6
[2019-10-03T21:22:54.522Z] github.com/go-swagger/go-swagger/cmd/swagger/commands.(*ValidateSpec).Execute(0x12305c8, 0xc00035cae0, 0x1, 0x2, 0x12305c8, 0x1)
[2019-10-03T21:22:54.522Z] 	/tmp/tmp.hjT43OgVuH/src/github.com/go-swagger/go-swagger/cmd/swagger/commands/validate.go:46 +0xf6
[2019-10-03T21:22:54.522Z] github.com/go-swagger/go-swagger/vendor/github.com/jessevdk/go-flags.(*Parser).ParseArgs(0xc0006a6960, 0xc000088160, 0x2, 0x2, 0x0, 0xc052b7, 0x2a, 0xa9a820, 0xc0006a8de0)
[2019-10-03T21:22:54.522Z] 	/tmp/tmp.hjT43OgVuH/src/github.com/go-swagger/go-swagger/vendor/github.com/jessevdk/go-flags/parser.go:315 +0x941
[2019-10-03T21:22:54.522Z] github.com/go-swagger/go-swagger/vendor/github.com/jessevdk/go-flags.(*Parser).Parse(...)
[2019-10-03T21:22:54.522Z] 	/tmp/tmp.hjT43OgVuH/src/github.com/go-swagger/go-swagger/vendor/github.com/jessevdk/go-flags/parser.go:185
[2019-10-03T21:22:54.522Z] main.main()
[2019-10-03T21:22:54.522Z] 	/tmp/tmp.hjT43OgVuH/src/github.com/go-swagger/go-swagger/cmd/swagger/swagger.go:90 +0x8bd
script returned exit code 2

@thaJeztah
Copy link
Member Author

ooooh; I guess one of the dependencies broke go-swagger; and they don't use vendoring, so likely it's now broken.

Looks like we may have to define our own vendoring to make it work again

@kolyshkin kolyshkin mentioned this pull request Oct 4, 2019
Merged
@kolyshkin
Copy link
Contributor

ooooh; I guess one of the dependencies broke go-swagger

Looks like the culprit is Golang 1.13.

The fix is here:

I have created a test PR to check if the fix is sufficient:

and they don't use vendoring, so likely it's now broken.

Looks like they do (and did).

@thaJeztah thaJeztah added the kind/bugfix PR's that fix bugs label Oct 10, 2019
@thaJeztah thaJeztah merged commit a8b04b1 into moby:master Oct 18, 2019
@thaJeztah thaJeztah deleted the session_endpoint_docs_updates branch October 18, 2019 23:18
trace-andreason pushed a commit to trace-andreason/moby that referenced this pull request Oct 19, 2019
@thaJeztah @trace-andreason
Merge pull request moby#40028 from thaJeztah/session_endpoint_docs_up…
a5839bb 
…dates

API: update docs that /session left experimental in V1.39
Signed-off-by: Trace Andreason <trace.andreason@lytics.com>
Signed-off-by: Trace <tandreason@gmail.com>
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborvass tiborvass tiborvass approved these changes

Assignees
No one assigned
Labels
area/api API area/builder Build area/docs impact/changelog kind/bugfix PR's that fix bugs process/cherry-picked status/3-docs-review
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @kolyshkin @tiborvass
0