8000 Fix go vet issue in daemon/daemon.go by yongtang · Pull Request #38497 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

Fix go vet issue in daemon/daemon.go #38497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2019
Merged

Fix go vet issue in daemon/daemon.go #38497

merged 1 commit into from
Jan 6, 2019

Conversation

yongtang
Copy link
Member
@yongtang yongtang commented Jan 5, 2019

Th 8000 is fix fixes go vet issue:

daemon/daemon.go:273: loop variable id captured by func literal
daemon/daemon.go:280: loop variable id captured by func literal

Signed-off-by: Yong Tang yong.tang.github@outlook.com

thaJeztah
thaJeztah approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daemon/daemon.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this was changed in #38301

/cc @cyphar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use c.Id?

cpuguy83
cpuguy83 approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get the if from c can't we?
In any case, this LGTM.

@yongtang
Fix go vet issue in daemon/daemon.go
7315a2b 
This fix fixes go vet issue:
```
daemon/daemon.go:273: loop variable id captured by func literal
daemon/daemon.go:280: loop variable id captured by func literal
```

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@codecov
Copy link
codecov bot commented Jan 6, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2ee53a4). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #38497   +/-   ##
=========================================
  Coverage          ?   36.62%           
=========================================
  Files             ?      608           
  Lines             ?    45174           
  Branches          ?        0           
=========================================
  Hits              ?    16545           
  Misses            ?    26340           
  Partials          ?     2289

@yongtang
Copy link
Member Author
yongtang commented Jan 6, 2019

@cpuguy83 @AkihiroSuda The PR has been updated.

@AkihiroSuda AkihiroSuda merged commit 16df93c into moby:master Jan 6, 2019
@yongtang yongtang deleted the go-vet branch January 6, 2019 04:07
@cyphar
Copy link
Contributor
cyphar commented Jan 14, 2019

LGTM. (late)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yongtang @cyphar @cpuguy83 @thaJeztah @AkihiroSuda @GordonTheTurtle
0