10BC0 libcontainerd: prevent exec delete locking by tonistiigi · Pull Request #38383 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

libcontainerd: prevent exec delete locking #38383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

libcontainerd: prevent exec delete locking #38383

merged 1 commit into from
Dec 17, 2018

Conversation

tonistiigi
Copy link
Member
@tonistiigi tonistiigi commented Dec 17, 2018 •
edited by thaJeztah
Loading

alternative for #38374
closes #38374

description: #38374 (comment)

@tonistiigi
libcontainerd: prevent exec delete locking
332f134 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@andrewhsu andrewhsu mentioned this pull request Dec 17, 2018
Merged
@crosbymichael
Copy link
Contributor

LGTM

andrewhsu
andrewhsu approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor
@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w.r.t. working around the deadlock for now

@andrewhsu andrewhsu mentioned this pull request Dec 17, 2018
Closed
@thaJeztah
Copy link
Member

Failure is unrelated

12:06:10 FAIL: docker_api_swarm_test.go:296: DockerSwarmSuite.TestAPISwarmLeaderElection

thaJeztah
thaJeztah approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 8422e6f into moby:master Dec 17, 2018
@tgross tgross mentioned this pull request Jan 10, 2019
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@andrewhsu andrewhsu andrewhsu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/runtime Runtime status/4-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tonistiigi @crosbymichael @thaJeztah @andrewhsu @GordonTheTurtle
0