Remove version-checks for containerd and runc #37968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With containerd reaching 1.0, the runtime now has a stable API, so there's no need to do a check if the installed version matches the expected version. Current versions of Docker now also package containerd and runc separately, and can be _updated_ separately. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
I think we still need to make sure the installed containerd is v1.2 or later |
|
The current code is only used to show if there's a mismatch (in the "docker info" output); there's no actual code to enforce the version.
If we need a version-check for 1.2.x, I guess we need to add that elsewhere (perhaps during startup of the daemon)
(version check can also be done in packaging probably)
… On 5 Oct 2018, at 01:49, Akihiro Suda ***@***.***> wrote:
I think we still need to make sure the installed containerd is v1.2 or later
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
AkihiroSuda
approved these changes
Oct 5, 2018
|
FWIW; I tried to keep changes minimal here, as I'll cherry-pick this for 18.09. I want to do follow-ups to;
|
Codecov Report
@@ Coverage Diff @@
## master #37968 +/- ##
=========================================
Coverage ? 36.12%
=========================================
Files ? 610
Lines ? 45143
Branches ? 0
=========================================
Hits ? 16310
Misses ? 26597
Partials ? 2236 |
This was referenced Oct 5, 2018
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With containerd reaching 1.0, the runtime now has a stable API, so there's no need to do a check if the installed version matches the expected version.
Current versions of Docker now also package containerd and runc separately, and can be updated separately.