8000 Increase raft ElectionTick to 10xHeartbeatTick by anshulpundir · Pull Request #36672 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

Increase raft ElectionTick to 10xHeartbeatTick #36672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2018
Merged

Increase raft ElectionTick to 10xHeartbeatTick #36672

merged 1 commit into from
Mar 23, 2018

Conversation

anshulpundir
Copy link
Contributor

Related change in swarmkit moby/swarmkit#2564
-->
@anshulpundir
Increase raft ElectionTick to 10xHeartbeatTick
6abee20 
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
cpuguy83
cpuguy83 approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM.

@codecov
Copy link
codecov bot commented Mar 23, 2018

Codecov Report

Merging #36672 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #36672      +/-   ##
==========================================
- Coverage   35.04%   35.02%   -0.03%     
==========================================
  Files         613      613              
  Lines       45562    45562              
==========================================
- Hits        15969    15958      -11     
- Misses      27486    27493       +7     
- Partials     2107     2111       +4
8000

@thaJeztah
Copy link
Member

Is a revendor of SwarmKit also needed, or is the code that changed there not used here?

@anshulpundir
Copy link
Contributor Author

Is a revendor of SwarmKit also needed, or is the code that changed there not used here?
We can revendor it, but its strictly not needed. @thaJeztah

@anshulpundir
Copy link
Contributor Author

BTW, can we merge it or is codecov/patch — 0% of diff hit (target 50%) a concern ? @cpuguy83 @thaJeztah

thaJeztah
thaJeztah approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

not sure if a test case is possible for this

@thaJeztah thaJeztah merged commit 5f17312 into moby:master Mar 23, 2018
@cpuguy83
Copy link
Member

It would be really nice to come up with a way to test network instability somewhere.

@anshulpundir anshulpundir deleted the election branch March 23, 2018 19:59
@anshulpundir
Copy link
Contributor Author

agreed. we're figuring out the approach to test this @cpuguy83

@thaJeztah thaJeztah mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anshulpundir @thaJeztah @cpuguy83 @GordonTheTurtle
0