10000 devmapper.Mounted: remove by kolyshkin · Pull Request #36437 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

devmapper.Mounted: remove #36437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2018
Merged

devmapper.Mounted: remove #36437

merged 1 commit into from
Mar 6, 2018
+0 −22

Conversation

kolyshkin
Copy link
Contributor

It looks like no one uses this function.

@kolyshkin
devmapper.Mounted: remove
0450f61 
It looks like no one uses this function.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
vdemeester
vdemeester reviewed Feb 28, 2018
View reviewed changes
Copy link
Member
@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM :angel:

thaJeztah
thaJeztah approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daemon/graphdriver/devmapper/mount.go
)

// FIXME: this is copy-pasted from the aufs driver.
// It should be moved into the core.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this was added a loooong time ago (4a8a7d4), and was to satisfy an interface that later changed (b8b509e / shykes#7). Looks like in aufs this is now moved to graphdriver.Mounted() (in 65d79e3):

moby/daemon/graphdriver/aufs/aufs.go

Lines 581 to 583 in 3a633a7

func (a *Driver) mounted(mountpoint string) (bool, error) {
return graphdriver.Mounted(graphdriver.FsMagicAufs, mountpoint)
}

@codecov
Copy link
codecov bot commented Mar 6, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1346a2c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36437   +/-   ##
=========================================
  Coverage          ?   34.91%           
=========================================
  Files             ?      613           
  Lines             ?    45365           
  Branches          ?        0           
=========================================
  Hits              ?    15839           
  Misses            ?    27426           
  Partials          ?     2100

@thaJeztah
Copy link
Member

ping @tonistiigi PTAL

cpuguy83
cpuguy83 approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member
@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit a6b1d2e into moby:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@runcom runcom Awaiting requested review from runcom

+1 more reviewer

@vdemeester vdemeester vdemeester left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/storage/devicemapper status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kolyshkin @thaJeztah @vdemeester @tonistiigi @cpuguy83 @GordonTheTurtle
0