[18.09 backport] Fix possible nil pointer exception #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as other back port. |
|
can you also add this commit? #2320 that fixes the gosimple |
|
Ah, need to backport #2320 to the release branches |
|
LOL, yes, so that ^^ haha |
|
ahah I was 3s faster :D |
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit fd6be31) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
I opened separate pull requests for them (for all the release branches) |
|
@thaJeztah the problem is that also this PR fix a gosimple issue. so the other PR will still fail |
|
Ah, gotcha; probably need to take just that bit from the PR to backport to 17.06 😕 |
It is possible that the node is not yet present in the node list map. In this case just print a warning and return. The next iteration would be fine Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit 1954e1c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
160db4f to
d20ece4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2325 for 18.09
relates to moby/moby#38618
cherry-pick was clean; no conflicts
It is possible that the node is not yet present in
the node list map. In this case just print a warning
and return. The next iteration would be fine