8000 Support `HyperVIsolation` option in containerd executor in Windows by Vigilans · Pull Request #6224 · moby/buildkit · GitHub
[go: up one dir, main page]
Skip to content

Support HyperVIsolation option in containerd executor in Windows #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

Support HyperVIsolation option in containerd executor in Windows #6224

merged 2 commits into from
Sep 16, 2025

Conversation

Vigilans
Copy link
Contributor

This is a continuation of review in #6206 (comment), and is the prerequisite of moby/moby#50942.

Instead of exposing an overly broad SpecOpts, this PR only exposes an Isolated flag to make buildkit create containers in Hyper-V VM in Windows.

The name Isolated is taken from the flag --isolated from ctr command in containerd:

var 
8000
platformRunFlags = []cli.Flag{
	&cli.BoolFlag{
		Name:  "isolated",
		Usage: "Run the container with vm isolation",
	},
}

if cliContext.Bool("isolated") {
	opts = append(opts, oci.WithWindowsHyperV)
}

@Vigilans
Support isolated option in containerd executor in Windows
2095093 
Signed-off-by: Vigilans <vigilans@foxmail.com>
@Vigilans Vigilans mentioned this pull request Sep 15, 2025
Closed
tonistiigi
tonistiigi reviewed Sep 16, 2025
View reviewed changes
@iankingori
Copy link
Contributor

closes #5682

@Vigilans
Rename isolated to hypervIsolation
30ef291 
Signed-off-by: Vigilans <vigilans@foxmail.com>
@Vigilans Vigilans changed the title Support isolated option in containerd executor in Windows Support HyperVIsolation option in containerd executor in Windows Sep 16, 2025
@Vigilans Vigilans mentioned this pull request Sep 16, 2025
Open
@tonistiigi tonistiigi merged commit b932279 into moby:master Sep 16, 2025
139 checks passed
@riverar
Copy link
riverar commented Sep 16, 2025

Thanks! Excited to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees

@Vigilans Vigilans

Labels
area/executor area/windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vigilans @iankingori @riverar @tonistiigi
0