Refactor containerd NewWorkerOpt & containerdexecutor New parameters
#5086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
AkihiroSuda
approved these changes
Jun 25, 2024
krissetto
approved these changes
Jun 25, 2024
jedevc
approved these changes
Jun 25, 2024
tonistiigi
approved th
8E9F
ese changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function parameters of
containerd.NewWorkerOptandcontainerdexecutor.Neware too long making it hard to read. This PR condenses the parameters into a singular struct.The struct naming could be adjusted, but since I'm not too familiar with the code I tried to stick with something similar to the package and function name.
Based off of this discussion #5033 (comment)