GDF test files #23
Merged
GDF test files #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains - one GDF version 1.25 file (openBCI) - one GDF version 2.20 file (biosemi2ft)
nbara
pushed a commit
to nbara/mne-python
that referenced
this pull request
Apr 21, 2017
Also remove test datafiles (see mne-tools/mne-testing-data#23)
larsoner
pushed a commit
to mne-tools/mne-python
that referenced
this pull request
Apr 28, 2017
* WIP: add basic GDF1 and GDF2 support only tested on a few GDF test files doesn't break existing EDF tests * Remove \x00 from channel names * Fix data calibration - Unified offset and calibration values for EDF/BDF/GDF modules - few PEP8 fixes - TODO: GDF 2.x triggers are detected as multiples of 256 - TODO: overflow and saturation detection * Proper imports imports in test_gdf.py * Fix to test_edf.py An additional warning has been added in edf.py when Lowpass information is not available in file header. As a result test_stim_channel() would fail. The test should now expect 2 warnings. * Separated EDF and GDF code - EDF and GDF file headers are now read in their own private subfunction - some PEP8 and cosmetic changes - GDF events are still multiples of 256 * Add biosig GDF test file make Travis happy * python3 fixes - python3 requires decoding the bytes objects to produce strings - np.unique() fails for dtype=object in python3 (see numpy/numpy#641) - flake, pydocstyle * Read biosemi GDF stim_channel properly * Speed up reading from file - fromstring -> fromfile * Test routines and added safechecks Also remove test datafiles (see mne-tools/mne-testing-data#23) * Update utils, and missing lowpass info no longer issues warning * Added stim_channel argument check * Address comments * Address comments and update doc * Address comments * Docstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains