MRG, FIX: Fix tick labeling #7811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
May 22, 2020
|
Annotation problem is upstream and unreleased (AFAIK) matplotlib/matplotlib#17489, so I'll merge once CIs come back happy here |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Sep 4, 2020
* FIX: Fix tick labeling * FIX: Add debugging
larsoner
added a commit
that referenced
this pull request
Sep 4, 2020
* FIX: Fix tick labeling * FIX: Add debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest
matplotlibcomplains ifset_x/yticklabels(...)count does not match the number of ticks, which is reasonable. This PR makes it so that we set them consistently, and tests now pass on my machine other than some issue withannotations, which I plan to also fix in this PR (hence the WIP).