MRG: Fix plot_montage #5676
Merged
MRG: Fix plot_montage #5676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review/merge from my end. Tests pass locally so I'm optimistic about CIs |
|
Ok, (it works on my machine) hopefully this should make travis green. |
|
Appveyor will be red, but if This travis is green we should get it in. |
agramfort
reviewed
Oct 29, 2018
doc/whats_new.rst
Outdated
| @@ -110,6 +110,8 @@ Bug | |||
|
|
|||
| - Fix bug with channel names in ``mgh70`` montage in :func:`mne.channels.read_montage` by `Eric Larson`_ | |||
|
|
|||
| - Fix check in :func:`mne.vis.plot_sensors` for inalid channel locations by `Eric Larson`_ | |||
agramfort
approved these changes
Oct 29, 2018
|
thx @larsoner |
Codecov Report
@@ Coverage Diff @@
## master #5676 +/- ##
==========================================
- Coverage 79.17% 73.01% -6.17%
==========================================
Files 368 368
Lines 68874 68864 -10
Branches 11615 11616 +1
==========================================
- Hits 54532 50278 -4254
- Misses 11720 16167 +4447
+ Partials 2622 2419 -203 |
This was referenced Oct 29, 2018
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually will fix what #5675 works around. This fixes that failure but introduces another. I see how to fix it but won't have time for a few hours.
np.nanpositions, plus test for allnp.nanSo @massich it's probably not worth merging #5675