Another bunch of MSVC related fixes and improvements #1199
Merged
+52
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a header only library with a single header (dirent.h). vcpkg installs this header with a custom logic to the global include path. However in other environments without modification upstream has to be treated like a usual library n cmake. "Linking" against the interface makes sure, that it is found and that the include paths are available for us. To conver both scenarios we use a FindDirent.cmake
Kwalify is used to validate MLT's YAML files, but it is not available for MSVC easily (eg. via vcpkg). This is only relevant for local setups, because for CI it is covered by other plattforms and the results of YAML validation are plattform independent
2f476ea to
beeff2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.