Fix CCA2 and alternative spellings for Norway #96
Conversation
NO is reserved keyword in YAML. It'll become `false` when loaded instead of literal NO. http://yaml.org/type/bool.html
|
This is going to be a bit of a pain to fix properly. The Symfony YAML component that is being used to dump the country data to YAML 'mostly' implements YAML 1.2 where boolean values can only be represented as I'm going to raise an issue with the Symfony Yaml component to ask if they would consider a patch to quote these values when dumping to YAML. |
|
@herrniemand I wasn't aware of this. As @petert82 said, the proper way to fix this issue is by fixing the Symfony YAML component. |
|
@sensen thank you for raising this issue, I'll close it for now and wait for a fix on the Symfony YAML component. |
|
Just for reference, this should be fixed once this PR is accepted. I'll make sure to keep an eye on it and update the composer.json here, if necessary once this is done. |
|
@petert82 very good, thank you! I'll keep an eye on it too. |
|
@mledoze I strongly recommend against closing such issues - why don't you wait with it open and not miss the issue when Symphony fixes things at their side? |
|
@shehi you're right, no problem. |
|
The pull request symfony/symfony#13262 has been merged into v2.6.4. I updated the dependencies in a3c480d. |
NO is reserved keyword in YAML. It'll become
falsewhen loaded insteadof literal NO.
http://yaml.org/type/bool.html