8000 Add Spanish translation (#20) by fdelapena · Pull Request #22 · misd-service-development/phone-number-bundle · GitHub
[go: up one dir, main page]
Skip to content

Add Spanish translation (#20) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2014
Merged

Add Spanish translation (#20) #22

merged 1 commit into from
Dec 13, 2014

Conversation

fdelapena
Copy link
Contributor

Includes generic Spanish which uses "celular" for mobile (mostly Latin America) and a specific Spanish from Spain version which uses "móvil" for mobile.

@thewilkybarkid
Copy link
Contributor

Thanks for helping!

I have been wondering what to do with Spanish. I'd say that when there's a split like this the general term should be 'mobile' then country-specific ones 'cellular' (as that refers to a specific implementation), which is what I've done with English (so en has mobile and en_US cellular). This does mean that there's 18 extra files with the extra translation (don't need to include units 1 and 2 in these).

Am I right in thinking Symfony doesn't support the es_419 (Latin-American Spanish) locale? That would remove this problem...

@fdelapena
Copy link
Contributor Author

Am I right in thinking Symfony doesn't support the es_419 (Latin-American Spanish) locale? That would remove this problem...

Is it not falling back from es_ES to es for translations?

@thewilkybarkid
Copy link
Contributor

Unfortunately not, Translator::computeFallbackLocales() will just take off the last part of the locale rather than using the ICU inheritance rules. I'll open an issue upstream, but I suspect we'll have to go with the separate files.

@thewilkybarkid thewilkybarkid mentioned this pull request Oct 25, 2014
Closed
@thewilkybarkid
Copy link
Contributor

No movement upstream, so I took a look at using a compiler pass to add in the inheritance. It's more complicated than I'd hoped, but does work (see thewilkybarkid@0524256).

So, could you change this PR so that es uses móvil and add in an es_419 file that just contains unit 3 with celular (so that it matches en and en_US)? Thanks.

@fdelapena
Copy link
Contributor Author

Thanks for your effort, I'll update the PR this weekend.

@thewilkybarkid
Copy link
Contributor

Thanks for that, would you mind just squashing the commits then I'll merge (and open a PR for the compiler pass).

@fdelapena
Copy link
Contributor Author

OK, I guess I need to close this one and create the rebase on a new branch to prevent rewriting public git history conflicts, isn't it?

@thewilkybarkid
Copy link
Contributor

There's no need to create a new one: the branch is just for a pull request so it's fine to rewrite the history (and a lot of repos will ask to do this - it's just to keep the commit history in the actual repo cleaner).

@fdelapena
Copy link
Contributor Author

OK, I have chance to do it this weekend.

@fdelapena
Copy link
Contributor Author

Ready.

@thewilkybarkid
Copy link
Contributor

Great, thanks! 😃

thewilkybarkid added a commit that referenced this pull request Dec 13, 2014
@thewilkybarkid
Merge pull request #22 from fdelapena/master
d5ccfa6 
Add Spanish translation (#20)
@thewilkybarkid thewilkybarkid merged commit d5ccfa6 into misd-service-development:master Dec 13, 2014
@thewilkybarkid thewilkybarkid mentioned this pull request Dec 13, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdelapena @thewilkybarkid
0