[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: jumppad.jumppad version 0.5.35 #115278

Merged
merged 1 commit into from
Aug 8, 2023
Merged

New package: jumppad.jumppad version 0.5.35 #115278

merged 1 commit into from
Aug 8, 2023

Conversation

eveld
Copy link
Contributor
@eveld eveld commented Aug 4, 2023 •
edited
Loading
  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=#115278

@eveld
Copy link
Contributor Author
eveld commented Aug 4, 2023

@microsoft-github-policy-service agree

@eveld
Copy link
Contributor Author
eveld commented Aug 4, 2023

Completed the checklist and installs successfully locally.

@Trenly
Copy link
Contributor
Trenly commented Aug 4, 2023

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Aug 4, 2023
@eveld
Copy link
Contributor Author
eveld commented Aug 7, 2023

Hi, is there anything we can do to move this forward? The tests seem to have all passed, but I am guessing the pipeline took too long to complete and therefor the validation failed even though everything was successful :(

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Aug 7, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 7, 2023
@microsoft-github-policy-service
Copy link
Contributor

eveld,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 6f6a167 into microsoft:master Aug 8, 2023
7 checks passed
@microsoft-github-policy-service
Copy link
Contributor

Hello eveld,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Executable-Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eveld @Trenly @wingetbot @stephengillie @AmelBawa-msft