Merged
Conversation
JohnMcPMS
previously approved these changes
Nov 15, 2025
Member
There was a problem hiding this comment.
I'm quite impressed that this is all it took. Maybe we are standards compliant at the moment.
JohnMcPMS
approved these changes
Nov 17, 2025
Merged
florelis
added a commit
that referenced
this pull request
Dec 1, 2025
Follow-up to #5882 to fix some issues I saw when building with VS2026. * Add back the setting for `ReleaseStatic` configuration that I deleted by accident. (The build error without this says that a the binary needs an entrypoint. So I'm assuming that without the `ConfigurationType` it assumes application instead of library.) * Added a missing include to a header. * Moved a template definition to be after the definition for a type it references. * Suppressed a warning from WIL code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solution does not build in VS 2026 because it defaults to using the v140 toolset (VS 2015), which is no longer supported.
This PR adds the configuration to use the latest toolset v145 in VS 2026 (v18), and removes the options for v140 (VS 2015) and v141 (VS 2017). I'm also setting this in the
Directory.Build.propsand removing the configuration from the individual projects.Microsoft Reviewers: Open in CodeFlow