fixed issue with left bracket in path to test file #17357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
For the linting issue, please make sure you use |
|
Hi Karthik, Thank you for your review and feedback! I accepted your changes and added additional check in case function is used outside the proper if. I also created an issue #17461 and added it to commit message, but it's unclear to me if they have link now (currently, I don't see a link between them). |
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
karthiknadig
approved these changes
Sep 22, 2021
|
Hi Karthik, I can't merge this PR - Only those with write access to this repository can merge pull requests. So it's up to you :) |
|
@ilexei I am waiting for @paulacamargo25 to take a look and merge. You don't have to do anything else for now :) |
mjpieters
added a commit
to mjpieters/vscode-python
that referenced
this pull request
Oct 30, 2021
Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for microsoft#17357, fixing microsoft#17676.
mjpieters
added a commit
to mjpieters/vscode-python
that referenced
this pull request
Oct 31, 2021
Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for microsoft#17357, fixing microsoft#17676.
mjpieters
added a commit
to mjpieters/vscode-python
that referenced
this pull request
Oct 31, 2021
Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for microsoft#17357, fixing microsoft#17676.
karthiknadig
added a commit
that referenced
this pull request
Nov 8, 2021
* Use pytest data to extract the parametrised decoration Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for #17357, fixing #17676. * Add news entry * Update news/2 Fixes/17676.md Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…ode-python#17881) * Use pytest data to extract the parametrised decoration Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for microsoft/vscode-python#17357, fixing microsoft/vscode-python#17676. * Add news entry * Update news/2 Fixes/17676.md Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I bumped into issue when pytest crashes on scanning my folders.
I had a structure like this
.
|-folder1-test_public.py
|-folder2-test_public.py
|-folder2[2]-test_public.py
And in case of folder folder2[2] the name of the test was determined wrong.
I searched the similar issue but found nothing.
Hope this little fix help not only me.