Provide a user setting to set default vmArgs#891
Merged
testforstephen merged 2 commits intomicrosoft:masterfrom Oct 12, 2020
Merged
Provide a user setting to set default vmArgs#891testforstephen merged 2 commits intomicrosoft:masterfrom
testforstephen merged 2 commits intomicrosoft:masterfrom
Conversation
b6956d5 to
ceaedf7
Compare
jdneo
reviewed
Oct 12, 2020
| "default": 3000, | ||
| "minimum": 100 | ||
| }, | ||
| "java.debug.settings.vmArgs": { |
Member
There was a problem hiding this comment.
Do you think if it is necessary to set it as machine scope?
Contributor
Author
There was a problem hiding this comment.
Seems not, because vmArgs is not auto executed by the debugger. It's like vmArgs in launch.json, need user to click debug to consume it.
jdneo
approved these changes
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #220
Close #876