8000 Improve launch.json auto-generation UX by Eskibear · Pull Request #342 · microsoft/vscode-java-debug · GitHub
[go: up one dir, main page]
Skip to content

Improve launch.json auto-generation UX #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eskibear merged 3 commits into from
Jul 19, 2018
Merged

Improve launch.json auto-generation UX #342

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
662a3a1
remove 'attach' config from default
Eskibear Jul 18, 2018
3c23c89
add default launch config with empty mainClass
Eskibear Jul 19, 2018
4317926
add back default attach config
Eskibear Jul 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions src/configurationProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,30 +34,36 @@ export class JavaDebugConfigurationProvider implements vscode.DebugConfiguration
return vscode.window.withProgress({location: vscode.ProgressLocation.Window}, (p) => {
return new Promise((resolve, reject) => {
p.report({message: "Auto generating configuration..."});
resolveMainClass(folder ? folder.uri : undefined).then((res: IMainClassOption []) => {
resolveMainClass(folder ? folder.uri : undefined).then((res: IMainClassOption[]) => {
let cache;
cache = {};
const defaultLaunchConfig = {
type: "java",
name: "Debug (Launch)",
request: "launch",
// tslint:disable-next-line
cwd: "${workspaceFolder}",
console: "internalConsole",
stopOnEntry: false,
mainClass: "",
args: "",
};
const launchConfigs = res.map((item) => {
return {
type: "java",
...defaultLaunchConfig,
name: this.constructLaunchConfigName(item.mainClass, item.projectName, cache),
request: "launch",
// tslint:disable-next-line
cwd: "${workspaceFolder}",
console: "internalConsole",
stopOnEntry: false,
mainClass: item.mainClass,
projectName: item.projectName,
args: "",
};
});
resolve([...launchConfigs, {
const defaultAttachConfig = {
type: "java",
name: "Debug (Attach)",
request: "attach",
hostName: "localhost",
port: 0,
}]);
port: "<debug port of remote debuggee>",
};
resolve([defaultLaunchConfig, ...launchConfigs, defaultAttachConfig]);
}, (ex) => {
p.report({message: `failed to generate configuration. ${ex}`});
reject(ex);
Expand Down Expand Up @@ -118,7 +124,7 @@ export class JavaDebugConfigurationProvider implements vscode.DebugConfiguration
return;
}
config.mainClass = userSelection.mainClass;
config.projectName = userSelection.projectName;
config.projectName = userSelection.projectName;
}
if (this.isEmptyArray(config.classPaths) && this.isEmptyArray(config.modulePaths)) {
const result = <any[]>(await resolveClasspath(config.mainClass, config.projectName));
Expand Down Expand Up @@ -209,7 +215,7 @@ export class JavaDebugConfigurationProvider implements vscode.DebugConfiguration
label: name,
item,
};
}).sort ((a, b): number => {
}).sort((a, b): number => {
return a.label > b.label ? 1 : -1;
});
const selection = pickItems.length > 1 ?
Expand Down
0