8000 Typo, add missing inline code markup by muzimuzhi · Pull Request #7589 · microsoft/vscode-docs · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@muzimuzhi
Copy link
Contributor

Add missing inline code markup for context names in api/references/when-clause-contexts.md, and normalize column names.

Add missing inline code markup for context names in
api/references/when-clause-contexts.md, and normalize
column names.
activeViewlet | True when view container is visible in the sidebar.<br>Example: `"activeViewlet == 'workbench.view.explorer'"`
activePanel | True when view container is visible in the panel.<br>Example: `"activePanel == 'workbench.panel.output'"`
activeAuxiliary | True when view container is visible in the secondary sidebar.<br>Example: `"activeAuxiliary == 'workbench.view.debug'"`
Context name | True when

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muzimuzhi is there any reason we changes Context key to Context name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because on the same page, "Context name" is used in the two other similar places, so I think "Context key" was an exception:

Context name | True when
------------ | ------------

Context name | True when
------------ | ------------

Context key | True when
--------------- | ------------

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for clarification


Context name | True when
------------ | ------------
Context name | True when

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Context name | True when
Context name | True when

Copy link
Contributor Author
@muzimuzhi muzimuzhi Sep 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added space makes the | on table title row aligned with that same characters on the separator row (------------- | ----------) and on the row for `focusedView`.

This table has only two content rows and currently the first row was made an exception, so the alignment pattern is a bit hard to observe...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. thanks

Copy link
Contributor
@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muzimuzhi thanks for being so meticulous in improving our docs!

@ntrogh ntrogh merged commit a53add7 into microsoft:main Sep 15, 2024
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 15, 2024
@muzimuzhi muzimuzhi deleted the markup/when-clause-contexts branch September 16, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0