-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Typo, add missing inline code markup #7589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| activeViewlet | True when view container is visible in the sidebar.<br>Example: `"activeViewlet == 'workbench.view.explorer'"` | ||
| activePanel | True when view container is visible in the panel.<br>Example: `"activePanel == 'workbench.panel.output'"` | ||
| activeAuxiliary | True when view container is visible in the secondary sidebar.<br>Example: `"activeAuxiliary == 'workbench.view.debug'"` | ||
| Context name | True when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muzimuzhi is there any reason we changes Context key to Context name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because on the same page, "Context name" is used in the two other similar places, so I think "Context key" was an exception:
vscode-docs/api/references/when-clause-contexts.md
Lines 142 to 143 in d239f68
| Context name | True when | |
| ------------ | ------------ |
vscode-docs/api/references/when-clause-contexts.md
Lines 260 to 261 in d239f68
| Context name | True when | |
| ------------ | ------------ |
vscode-docs/api/references/when-clause-contexts.md
Lines 291 to 292 in d239f68
| Context key | True when | |
| --------------- | ------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks for clarification
|
|
||
| Context name | True when | ||
| ------------ | ------------ | ||
| Context name | True when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Context name | True when | |
| Context name | True when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added space makes the | on table title row aligned with that same characters on the separator row (------------- | ----------) and on the row for `focusedView`.
This table has only two content rows and currently the first row was made an exception, so the alignment pattern is a bit hard to observe...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muzimuzhi thanks for being so meticulous in improving our docs!
Add missing inline code markup for context names in api/references/when-clause-contexts.md, and normalize column names.