10000 fix: add pfxBase64 to jsonCert instead of params by stevenfuhr · Pull Request #1746 · microsoft/playwright-java · GitHub
[go: up one dir, main page]

Skip to content

fix: add pfxBase64 to jsonCert instead of params #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

stevenfuhr
Copy link
Contributor
@stevenfuhr stevenfuhr commented Feb 7, 2025

This patch fixes PKCS12 client certificates not being added to the context. client_keystore is created from cert.pem and key.pem with password "passphrase".

Fixes #1747

This patch fixes PKCS12 client certificates not being added to the context
@stevenfuhr
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member
@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@yury-s yury-s merged commit 995cf90 into microsoft:main Feb 7, 2025
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PKCS12 client certificates not being picked up by browser context
2 participants
0