chore: roll driver to 1.53.0-alpha-2025-05-21 #3184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
commented
Jun 2, 2025
| @@ -402,18 +405,15 @@ public Task TapAsync(ElementHandleTapOptions? options = default) | |||
| public async Task<bool> IsVisibleAsync() => (await SendMessageToServerAsync("isVisible").ConfigureAwait(false))?.GetProperty("value").GetBoolean() ?? default; | |||
|
|
|||
| public async Task<string> InputValueAsync(ElementHandleInputValueOptions? options = null) | |||
| => (await SendMessageToServerAsync("inputValue", new Dictionary<string, object?>() | |||
| { | |||
| { "timeout", options?.Timeout }, | |||
There was a problem hiding this comment.
There is no timeout in the protocol for this method.
| @@ -842,9 +854,6 @@ public async Task<bool> IsHiddenAsync(string selector, FrameIsHiddenOptions? opt | |||
| => (await SendMessageToServerAsync("isHidden", new Dictionary<string, object?> | |||
| { | |||
| ["selector"] = selector, | |||
| #pragma warning disable CS0612 // Type or member is obsolete | |||
| ["timeout"] = options?.Timeout, | |||
There was a problem hiding this comment.
There is no timeout in the protocol for this method.
| @@ -853,9 +862,6 @@ public async Task<bool> IsVisibleAsync(string selector, FrameIsVisibleOptions? o | |||
| => (await SendMessageToServerAsync("isVisible", new Dictionary<string, object?> | |||
| { | |||
| ["selector"] = selector, | |||
| #pragma warning disable CS0612 // Type or member is obsolete | |||
| ["timeout"] = options?.Timeout, | |||
There was a problem hiding this comment.
There is no timeout in the protocol for this method.
| @@ -230,6 +230,6 @@ void ValidateCookies(IReadOnlyList<BrowserContextCookiesResult> cookies) | |||
| ValidateCookies(await Context.CookiesAsync("https://foo.com")); | |||
| ValidateCookies(await Context.CookiesAsync(null as string)); | |||
| ValidateCookies(await Context.CookiesAsync(null as string[])); | |||
| ValidateCookies(await Context.CookiesAsync([])); | |||
| // ValidateCookies(await Context.CookiesAsync([])); | |||
There was a problem hiding this comment.
This line does not compile for some reason. Needs investigation.
There was a problem hiding this comment.
Would be nice to find out why it regressed before we land.
| @@ -49,7 +49,6 @@ async Task<IAPIRequestContext> IAPIRequest.NewContextAsync(APIRequestNewContextO | |||
| ["httpCredentials"] = options?.HttpCredentials, | |||
| ["maxRedirects"] = options?.MaxRedirects, | |||
| ["proxy"] = options?.Proxy, | |||
| ["timeout"] = options?.Timeout, | |||
There was a problem hiding this comment.
This property was removed from the protocol.
| @@ -254,7 +255,6 @@ async Task<IBrowser> CreateBrowserAsync() | |||
| return playwright.PreLaunchedBrowser; | |||
| } | |||
| var task = CreateBrowserAsync(); | |||
| var timeout = options?.Timeout != null ? (int)options.Timeout : 30_000; | |||
There was a problem hiding this comment.
Upstream defaults to zero timeout instead of 30_000, aligned above.
mxschmitt
reviewed
Jun 2, 2025
| @@ -33,6 +33,17 @@ namespace Microsoft.Playwright; | |||
| /// Playwright script runs. | |||
| /// </para> | |||
| /// <para> | |||
| /// You probably want to <a href="https://playwright.dev/docs/api/class-testoptions#test-options-trace">enable | |||
| @@ -230,6 +230,6 @@ void ValidateCookies(IReadOnlyList<BrowserContextCookiesResult> cookies) | |||
| ValidateCookies(await Context.CookiesAsync("https://foo.com")); | |||
| ValidateCookies(await Context.CookiesAsync(null as string)); | |||
| ValidateCookies(await Context.CookiesAsync(null as string[])); | |||
| ValidateCookies(await Context.CookiesAsync([])); | |||
| // ValidateCookies(await Context.CookiesAsync([])); | |||
There was a problem hiding this comment.
Would be nice to find out why it regressed before we land.
8f24f68 to
5a5089d
Compare
mxschmitt
approved these changes
Jun 2, 2025
| @@ -415,6 +415,7 @@ private static (IReadOnlyList<TraceEventEntry> Events, Dictionary<string, byte[] | |||
| private class TraceEventEntry | |||
| { | |||
| public string Type { get; set; } | |||
| public string Title { get; set; } | |||
| public string ApiName { get; set; } | |||
There was a problem hiding this comment.
Suggested change
| public string ApiName { get; set; } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers microsoft/playwright#35888, microsoft/playwright#35969 and microsoft/playwright#35988.
References #3149.