8000 chore: evaluate `UtilityScript` lazily by dgozman · Pull Request #36019 · microsoft/playwright · GitHub
[go: up one dir, main page]
Skip to content

chore: evaluate UtilityScript lazily #36019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

chore: evaluate UtilityScript lazily #36019

merged 1 commit into from
May 21, 2025

Conversation

dgozman
Copy link
Contributor
@dgozman dgozman commented May 20, 2025 •
edited
Loading

This change stops evaluating UtilityScript lazily through an init script. As such, we no longer save builtins in a pristine world, and do not protect against Map/Set being tampered with.

Builtins protection turned out to be too complex to maintain, so we decided to offer evaluate, addInitScript and exposeBinding in the utility world instead, over time.

@dgozman dgozman added the CQ1 label May 20, 2025
@github-actions GitHub Actions
Copy link
8000 Contributor

Test results for "tests others"

4 failed
❌ [electron-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @electron-macos-latest
❌ [electron-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @electron-ubuntu-latest
❌ [electron-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @electron-windows-latest
❌ [webview2] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webview2-chromium-windows

4 flaky ⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @realtime-time-library-chromium-linux

22006 passed, 517 skipped
✔️✔️✔️

Merge workflow run.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 2"

67 failed
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @channel-chromium-macos-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @channel-chromium-ubuntu-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @channel-chromium-windows-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chrome-beta-macos-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chrome-beta-ubuntu-22.04
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chrome-beta-windows-latest
❌ [chromium-library] › library/proxy.spec.ts:254:3 › does launch without a port @chrome-macos-latest
❌ [chromium-library] › library/proxy.spec.ts:291:3 › should use SOCKS proxy for websocket requests @chrome-macos-latest
❌ [chromium-library] › library/proxy.spec.ts:326:3 › should use http proxy for websocket requests @chrome-macos-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chrome-macos-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chrome-ubuntu-22.04
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chrome-windows-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-headed-macos-14-xlarge
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-headed-ubuntu-24.04
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-headed-windows-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-macos-13-large
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-macos-13-xlarge
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-macos-14-large
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-macos-14-xlarge
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-tip-of-tree-headless-shell-ubuntu-22.04
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-tip-of-tree-macos-13
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-tip-of-tree-macos-13--headed
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-tip-of-tree-ubuntu-22.04--headed
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-tip-of-tree-windows-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-tip-of-tree-windows-latest--headed
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-ubuntu-24.04
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @chromium-windows-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @driver
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-beta-macos-latest
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-beta-ubuntu-22.04
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-beta-windows-latest
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-headed-macos-14-xlarge
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-headed-ubuntu-24.04
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-headed-windows-latest
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-macos-13-large
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-macos-13-xlarge
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-macos-14-large
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-macos-14-xlarge
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-ubuntu-24.04
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @firefox-windows-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @msedge-beta-macos-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @msedge-beta-ubuntu-22.04
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @msedge-dev-macos-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @msedge-dev-ubuntu-22.04
❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-macos-latest
❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @msedge-macos-latest
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @service
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @tracing-chromium
❌ [chromium-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @tracing-chromium-tip-of-tree
❌ [firefox-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @tracing-firefox
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @tracing-webkit
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-headed-macos-14-xlarge
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-headed-ubuntu-22.04
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-headed-ubuntu-24.04
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-headed-windows-latest
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-macos-13-large
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-macos-13-xlarge
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-macos-14-large
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-macos-14-xlarge
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-macos-15-large
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-macos-15-xlarge
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-ubuntu-24.04
❌ [webkit-page] › page/page-add-init-script.spec.ts:113:3 › init script should not observe playwright internals @webkit-windows-latest

137 flaky ⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:495:5 › run-server › should saveAs videos from remote browser @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python.spec.ts:133:5 › should work with --save-har @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest
⚠️ [chromium-library] › library/popup.spec.ts:258:3 › should not throw when click closes popup @channel-chromium-ubuntu-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › run-server › should throw when used after isConnected returns false @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:22:3 › should reject all promises when browser is closed @chrome-beta-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:180:5 › should connect to existing service workers @chrome-beta-macos-latest
⚠️ [chromium-library] › library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @chrome-beta-macos-latest
⚠️ [chromium-library] › library/downloads-path.spec.ts:32:5 › downloads path › should keep downloadsPath folder @chrome-beta-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:1027:3 › launchServer only › should be able to reconnect to a browser 12 times without warnings @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:36:5 › launch server › should work with port @chrome-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:209:5 › should connect over a ws endpoint @chrome-macos-latest
⚠️ [chromium-library] › library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:55:7 › cli codegen › should double click @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @chrome-macos-latest
⚠️ [chromium-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @chrome-macos-latest
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chromium-headed-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:759:5 › screencast › should capture full viewport on hidpi @chromium-macos-13-large
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencas 8000 t › should capture navigation @chromium-macos-13-xlarge
⚠️ [chromium-page] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked }) should have expected @chromium-macos-13-xlarge
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-beta-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-beta-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/title.spec.ts:35:5 › should update primary page URL when original primary closes @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-cookies.spec.ts:404:3 › iframe should inherit cookies from parent @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @firefox-headed-windows-latest
⚠️ [firefox-library] › library/hit-target.spec.ts:244:3 › should not click iframe overlaying the target @firefox-headed-windows-latest
⚠️ [firefox-library] › library/hit-target.spec.ts:398:3 › should click in iframe with padding @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:334:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:462:7 › cli codegen › should generate role locators undef frame locators @firefox-headed-windows-latest
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:67:3 › should scroll into view display:contents with position @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context @smoke @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-dev-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:125:5 › should connect to an existing cdp session twice @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy @smoke @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:178:3 › should exclude patterns @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:228:3 › should use socks proxy @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @msedge-dev-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @msedge-dev-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:43:5 › launch server › should work with wsPath @msedge-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox
⚠️ [webkit-library] › library/browsercontext-device.spec.ts:45:5 › device › should scroll to click @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-fetch-algorithms.spec.ts:53:9 › algorithms › deflate decompression › should not fail if response content-length header is missing (deflate) @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:684:7 › cli codegen › should await popup @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/elementhandle-misc.spec.ts:27:3 › should hover when Node is removed @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:199:7 › cli codegen › should work with TrustedTypes @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:559:7 › cli codegen › should check with keyboard @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:578:7 › cli codegen › should generate getByLabel @webkit-headed-ubuntu-24.04
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:473:7 › cli codegen › should fill tricky characters @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:520:7 › cli codegen › should generate getByPlaceholder @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:830:7 › cli codegen › should assert visibility @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @webkit-headed-windows-latest
⚠️ [webkit-library] › library/selector-generator.spec.ts:44:5 › selector generator › should prefer role=button over inner span @webkit-headed-windows-latest
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/wheel.spec.ts:185:3 › should scroll horizontally @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-macos-15-large
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-ubuntu-24.04

238921 passed, 9372 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman force-pushed the chore-do-not-inject-utility branch from 2b62669 to c6b9dbe Compare May 20, 2025 18:11
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
yury-s
yury-s approved these changes May 20, 2025
View reviewed changes
@dgozman dgozman force-pushed the chore-do-not-inject-utility branch from c6b9dbe to 5283fcd Compare May 21, 2025 08:18
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

3 failed
❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension
❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39211 passed, 804 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 6af4123 into microsoft:main May 21, 2025
28 of 31 checks passed
This was referenced May 21, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
CQ1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgozman @yury-s
0