8000 docs(tracing): clarify diff between test tracing and `context.tracing` by agg23 · Pull Request #35852 · microsoft/playwright · GitHub
[go: up one dir, main page]
Skip to content

docs(tracing): clarify diff between test tracing and context.tracing #35852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2025
Merged

docs(tracing): clarify diff between test tracing and context.tracing #35852

merged 5 commits into from
May 6, 2025

Conversation

agg23
Copy link
Contributor
@agg23 agg23 commented May 5, 2025

Explicitly document that context.tracing cannot trace everything that Playwright Test tracing can trace. Anything that stays local to the runner is not traced.

@agg23 agg23 requested a review from dgozman May 5, 2025 17:04
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
dgozman
dgozman reviewed May 6, 2025
View reviewed changes
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@agg23 agg23 closed this May 6, 2025
@agg23 agg23 reopened this May 6, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@agg23 agg23 merged commit 00429ef into microsoft:main May 6, 2025
28 of 29 checks passed
This was referenced May 6, 2025
Closed
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 6, 2025

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39132 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agg23 @dgozman
0