8000 chore: inject builtins through esbuild by dgozman · Pull Request #35800 · microsoft/playwright · GitHub
[go: up one dir, main page]
Skip to content

chore: inject builtins through esbuild #35800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

chore: inject builtins through esbuild #35800

merged 1 commit into from
Apr 29, 2025

Conversation

dgozman
Copy link
Contributor
@dgozman dgozman commented Apr 29, 2025 •
edited
Loading

There are multiple changes:

  • builtins are now injected through esbuild instead of being imported explicitly;
  • UtilityScript is now always evaluated through an init script;
  • pageBinding.ts is merged into the utility script;
  • builtins are now stored on the utility script instance;
  • all generated scripts are preprocessed before evaluation to include runtimeGuid.

References #35683.

@dgozman
chore: inject builtins through esbuild
6c914d1 
There are multiple changes:
- builtins are now injected through esbuild instead of being imported explicitly;
- `UtilityScript` is now always evaluated through an init script;
- `pageBinding.ts` is merged into the utility script;
- builtins are now stored on the utility script instance;
- all generated scripts are preprocessed before evaluation to include `runtimeGuid`.
@dgozman dgozman added the CQ1 label Apr 29, 2025
@dgozman dgozman requested a review from pavelfeldman April 29, 2025 16:48
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests others"

1 fatal errors, not part of any test

3 flaky ⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest

19924 passed, 457 skipped
✔️✔️✔️

Merge workflow run.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [default] › run-tests.spec.ts:1153:5 › should produce output twice @vscode-extension

6 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39106 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 2"

1 fatal errors, not part of any test
20 failed
❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @channel-chromium-macos-latest
❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-macos-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-macos-latest
❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-ubuntu-22.04
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-ubuntu-22.04
❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-ubuntu-22.04
❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-ubuntu-22.04
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-windows-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-windows-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest
❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest
❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04
❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge

166 flaky ⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest
⚠️ [chromium-library] › library/ 8000 inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context @smoke @channel-chromium-macos-latest
⚠️ [chromium-library] › library/page-clock.spec.ts:327:3 › popup › should run time before popup @channel-chromium-ubuntu-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-macos-latest
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-macos-latest
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-macos-latest
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-ubuntu-22.04
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-windows-latest
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:146:5 › should upload large file @chrome-windows-latest
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-macos-14-xlarge
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:184:7 › cli codegen › should generate frame locators (3) @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-macos-14-large
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers @smoke @chromium-tip-of-tree-macos-13
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1202:1 › should open trace-1.31 @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context @smoke @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest--headed
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest
⚠️ [firefox-library] › library/global-fetch-cookie.spec.ts:130:1 › should send secure cookie over http for localhost @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-beta-macos-latest
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:430:7 › cli codegen › should generate frame locators with testId @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @firefox-headed-windows-latest
⚠️ [firefox-library] › library/slowmo.spec.ts:55:5 › slowMo › Page SlowMo check @firefox-headed-windows-latest
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-13-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › launchServer › should throw when used after isConnected returns false @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy @smoke @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-dev-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1016:1 › should include metainfo @msedge-dev-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-macos-latest
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy @smoke @msedge-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-macos-latest
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-ubuntu-22.04
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @tracing-webkit
⚠️ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @tracing-webkit
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/page-screenshot.spec.ts:468:7 › page screenshot › mask option › should work with elementhandle @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/page-screenshot.spec.ts:556:7 › page screenshot › mask option › should work when mask color is not pink #F0F @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-ubuntu-24.04
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @webkit-headed-windows-latest
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-headed-windows-latest
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:285:5 › post data › should amend binary post data @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @we 8000 bkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-page] › page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-macos-15-xlarge

234422 passed, 9209 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 3b01354 into microsoft:main Apr 29, 2025
89 of 108 checks passed
This was referenced Apr 29, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
CQ1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgozman @pavelfeldman
0