Fix validateGlobalParam test on ADO pipelines #5600
+93
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5600 +/- ##
==========================================
+ Coverage 84.81% 85.75% +0.93%
==========================================
Files 60 60
Lines 18647 18647
==========================================
+ Hits 15816 15991 +175
+ Misses 2831 2656 -175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
validateGlobalParamtest has been failing on the ADO pipeline.This seems to be due to the
QuicTestValidateRegistrationtest now creating registration for real, which triggers the lazy initialization of the Quic library and creates a datapath.These API tests assume nothing has been initialized and test for failure path.
Instead, move the test to the "basic test" file.
As a follow up, we should consider making test truly independent by not creating the MsQuic library globally.
Testing
Test update
Documentation
N/A