Merged
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
andxu
reviewed
Nov 13, 2019
com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/Watchpoint.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 13, 2019
com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/Watchpoint.java
Show resolved
Hide resolved
andxu
reviewed
Nov 13, 2019
|
|
||
| requests.addAll(watchpointRequests); | ||
| if (!watchpointRequests.isEmpty() && !future.isDone()) { | ||
| this.putProperty("verified", true); |
Contributor
There was a problem hiding this comment.
this.putProperty("verified", true); twice ? see line 159
Contributor
Author
There was a problem hiding this comment.
By design. It's guarded by the condition check !future.isDone()
Contributor
There was a problem hiding this comment.
List watchpointRequests = createWatchpointRequests(event.referenceType());
requests.addAll(watchpointRequests);
if (!watchpointRequests.isEmpty() && !future.isDone()) {
this.putProperty("verified", true);
future.complete(this);
}
duplicate
andxu
reviewed
Nov 13, 2019
...t.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/BreakpointManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
andxu
reviewed
Nov 15, 2019
|
|
||
| @Override | ||
| public String getLogMessage() { | ||
| return null; |
Contributor
There was a problem hiding this comment.
throw UnsupportedException rather than null/do nothing logic
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
andxu
previously approved these changes
Nov 15, 2019
Contributor
There was a problem hiding this comment.
Please write unit tests for new code.
…g into jinbo_databreakpoint
andxu
approved these changes
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
Close microsoft/vscode-java-debug#654