Merged
Conversation
* Redefine HCR event. * bump version to 0.5.0 Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
andxu
added a commit
that referenced
this pull request
Dec 19, 2017
…eException (#131) * 1. replace JdiObjectProxy with StackFrameProxy, because only stackframe uses it . * 1. add a missing import. * rename a variable * fix compilation error after merge * 1. add lock to prevent concurrent stackframe access 2. redefine the StackFrameProxy to only have thread and depth since the stackframe instance may be out of date 3. add stackframe provider and add logic to update stackframe during evaluation. * add stackframe provider and add logic to update stackframe during evaluation. * fix for a better flow * fix for a better flow * revert minor changes which is not needed. * remove useless lines. * clean evaluation inner states when the thread is to be continued. * clean evaluation inner states when the thread is to be continued. * lock on acquireEvaluationLock * remove the duplicate expr check * revert unneeded change * refine if-else flow. * redefine the lock * change another method to override indicating sf is updated. * rename some classes suggested by reviewer * 1. refact variableProxy to contain thread reference, 2. stackframes/varaible/setVariable/evaluate will first gain the thread lock on stack frame manager. * some minor changes of spaces and javadoc. * convert to supplyAsync with try logic to handle lock * Andy eval20 (#138) * Redefine HCR event. (#133) * Sequentially process debug requests (#135) * bump version to 0.5.0 (#136) * Redefine HCR event. * bump version to 0.5.0 Signed-off-by: Jinbo Wang <jinbwan@microsoft.com> * don't use lock * don't use lock * don't use lock * Minor changes: indentation, rename code -> expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.