fix: When both -Q and -q are specified, take -Q input and finish #547

martinkunc · 2024-08-10T10:51:38Z

Would this be a good fix for the issue #525 when both -Q and -q are specified.

By switching priority, when both are specified, it takes -Q first, and finishes. The app no more crashes.

If we would like to report error instead, maybe I could do it in another PR.

Example output

> ./sqlcmd -S "tcp:127.0.0.1,1433" -E -d master -q "SELECT 1" -Q "SELECT 2"

-----------
          2

(1 row affected)

shueybubbles · 2024-08-13T15:49:00Z

thx for opening a PR!
I think mimicking ODBC is the right thing.
Please add a test that fails without your fix.

>"C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn\SQLCMD.EXE" -Q "select 'Q'" -q "select 'q'"

-
Q

(1 rows affected)

fix: When both -Q and -q are specified, take -Q input and finish

08f12e4

Add test for both init query and query to verify query was executed

a8da898

shueybubbles requested review from apoorvdeshmukh and stuartpa August 13, 2024 19:25

shueybubbles approved these changes Aug 13, 2024

View reviewed changes

apoorvdeshmukh approved these changes Aug 14, 2024

View reviewed changes

shueybubbles merged commit 412fe02 into microsoft:main Aug 14, 2024

Provide feedback