8000 Fix mac builds by apoorvdeshmukh · Pull Request #418 · microsoft/go-sqlcmd · GitHub
[go: up one dir, main page]
Skip to content

Fix mac builds #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apoorvdeshmukh merged 2 commits into from
Jul 9, 2023
Merged

Fix mac builds #418

apoorvdeshmukh merged 2 commits into from
Jul 9, 2023

Conversation

@apoorvdeshmukh
Copy link
Contributor
@apoorvdeshmukh apoorvdeshmukh commented Jul 8, 2023

Mac builds failed with following error

# github.com/microsoft/go-sqlcmd/cmd/modern/root/open
root/open/ads_darwin.go:31:14: undefined: localizer
##[error]The Go task failed with an error: Error: The process '/Users/runner/hostedtoolcache/go/1.18.0/x64/bin/go' failed with exit code 2

VS Code did not throw errors/warning as it warned that this file is within mdule "." which is not included in workspace.

shueybubbles
shueybubbles approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator
@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

:shipit:

@apoorvdeshmukh apoorvdeshmukh merged commit ad518e3 into main Jul 9, 2023
@apoorvdeshmukh apoorvdeshmukh deleted the apoorvdeshmukh/fixMacBuilds branch July 9, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shueybubbles shueybubbles shueybubbles approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apoorvdeshmukh @shueybubbles
0