This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Add JsonSerializerIsReflectionEnabledByDefault to props file#431
Merged
vineeththomasalex merged 1 commit intomainfrom Aug 16, 2024
Merged
Add JsonSerializerIsReflectionEnabledByDefault to props file#431vineeththomasalex merged 1 commit intomainfrom
vineeththomasalex merged 1 commit intomainfrom
Conversation
krschau
approved these changes
Aug 16, 2024
dkbennett
approved these changes
Aug 16, 2024
EricJohnson327
pushed a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Vineeth Thomas Alex <vithoma@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Fixes an issue with JsonSerializerOptions caused by this breaking change in .Net8 that is mysteriously not hitting on Dev builds (not just my computer).
Similar to https://github.com/microsoft/DevHomeAzureExtension/pull/135/files
References and relevant issues
Follow up to #426.
Detailed description of the pull request / Additional comments
Added JsonSerializerIsReflectionEnabledByDefault.
Validation steps performed
Tested Dev build.
PR checklist